refactor: Scoped imports #1832
Open
refactor: Scoped imports #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hello @CrownedPhoenix, Thank you for this pull request! Does GRDB build for WebAssembly with those changes? |
Author
No - or at least I don't think it will (I haven't tried yet because I am pretty sure DispatchQueue won't compile for WASM). This is merely preparatory so that in the future when we (myself or one of my colleagues) come back around to try to get WASM building it will be easier to do the dependency analysis/pruning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audits all imports of
DispatchandFoundationto use scoped imports instead of global imports.I'm doing this as a very non-disruptive bit of lookahead for a hope of getting someday getting GRDB to build for WebAssembly. Been down this road before and Foundation and Dispatch are libraries that have some bits that don't compile well for WASM. My intent with this changeset is to make it easier down the road to identify the symbols and places that need to be #if-def'd around and/or implemented in a WASM-friendly way.
TL;DR This will make dependency pruning down the road much simpler.
Pull Request Checklist
developmentbranch.make smokeTestterminal command runs without failure. (N/A)